Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace_root variable expansion in paths field #2503

Closed
wants to merge 1 commit into from

Conversation

bobot
Copy link
Collaborator

@bobot bobot commented Aug 2, 2019

follow-up of #2476. It gives a way to reference the source directory by using %{workspace_root}.

Signed-off-by: François Bobot <francois.bobot@cea.fr>
@rgrinberg
Copy link
Member

Could you also support project_root? Actually using workspace_root should really be discouraged as it makes your dune build non-composable. I'm on the fence on whether we should be adding more support for it.

@nojb
Copy link
Collaborator

nojb commented Aug 3, 2019

Could you also support project_root? Actually using workspace_root should really be discouraged as it makes your dune build non-composable. I'm on the fence on whether we should be adding more support for it.

True; but (paths) is only supported on dune-workspace for now, so it wouldn't make sense to use project_root, right? Maybe we should wait until there is support for (paths) in dune files and only do the expansion there?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from master to main January 14, 2021 17:08
@rgrinberg
Copy link
Member

@bobot closing as this stale. feel free to re-open if you rebase.

@rgrinberg rgrinberg closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants