-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glob support to dune-action-plugin
#2646
Merged
aalekseyev
merged 14 commits into
ocaml:master
from
aalekseyev:dune_action_plugin_glob_support
Oct 8, 2019
Merged
Add glob support to dune-action-plugin
#2646
aalekseyev
merged 14 commits into
ocaml:master
from
aalekseyev:dune_action_plugin_glob_support
Oct 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalekseyev
requested review from
emillon,
nojb and
rgrinberg
as code owners
September 17, 2019 09:59
aalekseyev
force-pushed
the
dune_action_plugin_glob_support
branch
2 times, most recently
from
September 17, 2019 10:01
f3b9edf
to
48d17f8
Compare
Signed-off-by: Jakub Staron <jstaron@janestreet.com> Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
aalekseyev
force-pushed
the
dune_action_plugin_glob_support
branch
from
September 17, 2019 10:12
48d17f8
to
3148590
Compare
let-def
pushed a commit
to let-def/opam-repository
that referenced
this pull request
Sep 17, 2019
CHANGES: - Fix config file dependencies of ocamlformat (ocaml/dune#2471, fixes ocaml/dune#2646, @nojb) - Cleanup stale directories when using `(source_tree ...)` in the presence of directories with only sub-directories and no files (ocaml/dune#2514, fixes ocaml/dune#2499, @diml)
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
…, I'm sorry. Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
ghost
reviewed
Sep 18, 2019
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
…gin_glob_support' into dune_action_plugin_glob_support
ghost
mentioned this pull request
Sep 18, 2019
rgrinberg
requested changes
Oct 7, 2019
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
ghost
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
…ev/dune into dune_action_plugin_glob_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following function to
Dune_action_plugin
:This gives you a more fine-grained control over your dependencies.