Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob support to dune-action-plugin #2646

Merged
merged 14 commits into from
Oct 8, 2019

Conversation

aalekseyev
Copy link
Collaborator

@aalekseyev aalekseyev commented Sep 17, 2019

Add the following function to Dune_action_plugin:

val read_directory_with_glob : path:Path.t -> glob:Glob.t -> string list t

This gives you a more fine-grained control over your dependencies.

@aalekseyev aalekseyev requested a review from a user September 17, 2019 09:59
@aalekseyev aalekseyev force-pushed the dune_action_plugin_glob_support branch 2 times, most recently from f3b9edf to 48d17f8 Compare September 17, 2019 10:01
Signed-off-by: Jakub Staron <jstaron@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
@aalekseyev aalekseyev force-pushed the dune_action_plugin_glob_support branch from 48d17f8 to 3148590 Compare September 17, 2019 10:12
let-def pushed a commit to let-def/opam-repository that referenced this pull request Sep 17, 2019
CHANGES:

- Fix config file dependencies of ocamlformat (ocaml/dune#2471, fixes ocaml/dune#2646,
  @nojb)

- Cleanup stale directories when using `(source_tree ...)` in the
  presence of directories with only sub-directories and no files
  (ocaml/dune#2514, fixes ocaml/dune#2499, @diml)
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
…, I'm sorry.

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
…gin_glob_support' into dune_action_plugin_glob_support
@ghost ghost mentioned this pull request Sep 18, 2019
src/dune_action_plugin/glob.ml Outdated Show resolved Hide resolved
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
…ev/dune into dune_action_plugin_glob_support
@aalekseyev aalekseyev merged commit c67d6ac into ocaml:master Oct 8, 2019
@aalekseyev aalekseyev deleted the dune_action_plugin_glob_support branch October 8, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants