Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package dependency handling #3424

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Package dependency handling #3424

merged 1 commit into from
Apr 29, 2020

Conversation

rgrinberg
Copy link
Member

  • Properly error on missing packages in (package ..) definitions
  • Move -files aliases to the package dir. This makes rule loading
    lazier.

@rgrinberg
Package dependency handling
4dc2d46 
* Properly error on missing packages in (package ..) definitions
* Move <pkg>-files aliases to the package dir. This makes rule loading
lazier.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg requested review from snowleopard, a user and aalekseyev April 25, 2020 02:42
ghost
ghost approved these changes Apr 29, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rgrinberg rgrinberg merged commit 0bff553 into ocaml:master Apr 29, 2020
@rgrinberg rgrinberg mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowleopard snowleopard Awaiting requested review from snowleopard

@aalekseyev aalekseyev Awaiting requested review from aalekseyev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rgrinberg