New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups from #3655 #3814

Merged

rgrinberg merged 2 commits into ocaml:master from rgrinberg:private-package-lib-refactors

Sep 23, 2020

Member

rgrinberg commented Sep 22, 2020

Unrelated changes from #3655 that make it easier to review the other PR.

We change lib.public to visibility. This is consistent with how we handle
private/public everywhere else.
lib_entries_by_package is moved to own function

rgrinberg added 2 commits

September 22, 2020 16:25


          Move create lib entries to own function

eebee9a

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>


          Rename library.public to library.visibility

9f891e6

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

rgrinberg requested review from a user, nojb and bobot and removed request for a user

September 22, 2020 23:43

bobot approved these changes

View reviewed changes

Collaborator

bobot left a comment

Functionally the same as before with reasonable clarifications.

rgrinberg merged commit 645f4ed into ocaml:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet