Replace Unix.select with Unix.sleepf

[rgrinberg]

select had no arguments, so it's the same as a sleep.

[nojb]

Looks OK, but I will play with it today just in case.

[nojb]

LGTM.

I tested a full rebuild of our codebase under Windows before and after the PR, to make sure there weren't any big timing regressions.

[rgrinberg]

I tested a full rebuild of our codebase under Windows before and after the PR, to make sure there weren't any big timing regressions.

Let's see if @dra27 approves to be extra safe.

[dra27]

Why not just use Unix.sleepf? I expect that at the time it was written we still supported 4.02.3 for building?

[rgrinberg]

Why not just use Unix.sleepf

Mostly because we use Thread.delay elsewhere in this module. Isn't it the same though?

[dra27]

Indeed - Thread.delay is an alias for Unix.sleepf - I sort of prefer sleep (which implies spinning) to delay (which implies timing) 🙂

Incidentally, it used to be Unix.sleepf, I had remembered correctly that it was changed for 4.02.3 compat: 27a2994#diff-2ab64c3235ac84078222643eddc2bb55bd20b98688ecc9c807dadb4bba96a6f7