Install .cmxs with the executable bit set
#4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobot
changed the title
.cmxs with the install bit set.cmxs with the executable bit set
bobot
force-pushed
the
fix_cmxs_not_exec
branch
2 times, most recently
from
68efb1b to
86b0015
Compare
rgrinberg
approved these changes
Jan 22, 2021
bobot
force-pushed
the
fix_cmxs_not_exec
branch
2 times, most recently
from
578770c to
5b848e1
Compare
|
But I don't understand why I had to run |
Fixes ocaml#4148 Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot
force-pushed
the
fix_cmxs_not_exec
branch
from
5b848e1 to
3d446a8
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Mar 29, 2021
…ne-action-plugin, dune-private-libs and dune-glob (2.8.5) CHANGES: - Fixed absence of executable bit for installed `.cmxs` (ocaml/dune#4149, fixes ocaml/dune#4148, @bobot) - Fix a race in Dune cache. It was particularly easy to hit this race when using the cache on Windows (ocaml/dune#4406, fixes ocaml/dune#4167, @snowleopard)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4148