Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run exit hooks before Unix.exec'ing #4260

Merged
merged 1 commit into from
Feb 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ Unreleased
- Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in
Path.touch on Windows (#4223, @dra27)

- Cleanup temporary files after running `$ dune exec`. (#4260, fixes #4243,
@rgrinberg)

2.8.2 (21/01/2021)
------------------

Expand Down
1 change: 1 addition & 0 deletions src/stdune/proc.ml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@ let restore_cwd_and_execve prog argv ~env =
| WSTOPPED _ -> assert false
else (
ignore (Unix.sigprocmask SIG_SETMASK [] : int list);
Stdlib.do_at_exit ();
Unix.execve prog argv env
)