Workaround opam config var being removed in Opam 2.1
#4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
changed the title
opam config var being deprecated in Opam 2.1opam config var being removed in Opam 2.1
emillon
reviewed
May 21, 2021
There was a problem hiding this comment.
Yes, that works for opam >= 2.0. As we said in a meeting a couple months ago, we are going to drop support for opam 1.x in 3.0 anyway. Note that the version in the opam file is only relevant for users that install dune through opam - it's still possible to use a dune binary installed from somewhere else and (before this PR) it will be able to detect and interact with an opam 1 system.
FTR, this happened in #4280. There is even a version check. |
|
Just rebased, green light to merge ? |
ghost
approved these changes
Jun 1, 2021
|
Go for it |
Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently updated to a beta version of Opam 2.1 and the following error shows when using
opam config var prefix:Two mitigations are possible:
OPAMCLI=2.0opam var prefixinsteadThis PR implements option 2. However if I am not mistaken this will only work with
opam >= 2.0and I don't know if that is a satisfying constraint for Dune ?Edit: the opam file does stateopam-version: "2.0"so I guess this is not an issue.