Update docs 090921 #4913
Merged
Update docs 090921 #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christine Rose <professor.rose@gmail.com>
Signed-off-by: Christine Rose <professor.rose@gmail.com>
rgrinberg
reviewed
Sep 11, 2021
Signed-off-by: Christine Rose <professor.rose@gmail.com>
Signed-off-by: Christine Rose <professor.rose@gmail.com>
Signed-off-by: Christine Rose <professor.rose@gmail.com>
Signed-off-by: Christine Rose <professor.rose@gmail.com>
…/dune into update_docs_090921
|
@christinerose this PR accidentally scrambled some of the dos we looked at together in #4921. I just noticed this while reviewing #5206. It seems that git did something weird while merging. In the future, it's probably worth glancing at the changes again after a merge. Doing a rebase rather than a merge should generally be safer. |
ghost
mentioned this pull request
|
FTR, I re-did the changes in main. |
|
Thank you! I’ll do a rebase next time then. 😊 |
|
Is it okay to delete this branch now? |
|
Yes, generally you can delete a branch as soon as it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docs on new branch to avoid merge conflicts and work around the signoff error