-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(watch): track looked up binaries #5008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once add_exe
gets a doc comment.
Now dune's watch mode will be responsive when binaries it uses changes. Note: some basic binaries are exempt from this ($vcs, cygpath, bash, sh, etc.) Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This seems to have broken things. Now I'm getting:
|
That's weird, the directory clearly exists for you. Any idea what's happening @snowleopard |
It doesn't actually. But it is in my |
I see. So you don't even have /usr/local? We should definitely handle this. Will send a fix |
I have /usr/local but not /usr/local/bin |
@rgrinberg did you get a chance to look at this? I still have edit my |
I fixed it for the fsevents backend in #4990. Can we get that PR merged and I'll do a fix for inotify. I've crammed enough into one PR already :) |
Now dune's watch mode will be responsive when binaries it uses changes.
Note: some basic binaries are exempt from this ($vcs, cygpath, bash, sh,
etc.)