Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak flags for 3.3 #5844

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix: tweak flags for 3.3 #5844

merged 1 commit into from
Jun 14, 2022

Conversation

rgrinberg
Copy link
Member

Enable flags that are of the "unused X" form. This is consistent with
our other flags

This was discussed and approved at the dune meeting at some point, but I forgot to submit the PR.

@rgrinberg rgrinberg requested review from emillon and nojb June 7, 2022 21:45
@rgrinberg rgrinberg added this to the 3.3.0 milestone Jun 7, 2022
@rgrinberg rgrinberg force-pushed the ps/rr/fix__tweak_flags_for_3_3 branch 3 times, most recently from ee68ce4 to c228af6 Compare June 9, 2022 01:57
Enable flags that are of the "unused X" form. This is consistent with
our other flags

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: 23F2BB36-7B2F-4277-BFA2-81A20A1F7A65
@emillon emillon force-pushed the ps/rr/fix__tweak_flags_for_3_3 branch from c228af6 to c561a30 Compare June 14, 2022 08:30
@emillon emillon merged commit 3eff810 into main Jun 14, 2022
kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this pull request Jun 17, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.3.0)

CHANGES:

- Sandbox preprocessing, lint, and dialect rules by default. All these rules
  now require precise dependency specifications (ocaml/dune#5807, @rgrinberg)

- Allow list expansion in the `pps` specification for preprocessing (ocaml/dune#5820,
  @Firobe)

- Add warnings 67-69 to dune's default set of warnings. These are warnings of
  the form "unused X.." (ocaml/dune#5844, @rgrinbreg)

- Introduce project "composition" for coq theories. Coq theories in separate
  projects can now refer to each other when in the same workspace (ocaml/dune#5784,
  @Alitzer, @rgrinberg)

- Fix hint message for ``data_only_dirs`` that wrongly mentions the unknown
  constructor ``data_only`` (ocaml/dune#5803, @lambdaxdotx)

- Fix creating sandbox directory trees by getting rid of buggy memoization
  (@5794, @rgrinberg, @snowleopard)

- Handle directory dependencies in sandboxed rules. Previously, the parents of
  these directory dependencies weren't created. (ocaml/dune#5754, @rgrinberg)

- Set the exit code to 130 when dune is terminated with a signal (ocaml/dune#5769, fixes
  ocaml/dune#5757)

- Support new locations of unix, str, dynlink in OCaml >= 5.0 (ocaml/dune#5582, @dra27)

- The ``coq.theory`` stanza now produces rules for running ``coqdoc``. Given a
  theory named ``mytheory``, the directory targets ``mytheory.html/`` and
  ``mytheory.tex/`` or additionally the aliases `@doc` and `@doc-latex` will
  build the HTML and LaTeX documentation repsectively. (ocaml/dune#5695, fixes ocaml/dune#3760,
  @Alizter)

- Coq theories marked as `(boot)` cannot depend on other theories
  (ocaml/dune#5867, @ejgallego)

- Ignore `bigarray` in `(libraries)` with OCaml >= 5.0. (ocaml/dune#5526, fixes ocaml/dune#5494,
  @moyodiallo)

- Start with :standard when building the ctypes generated foreign stubs so that
  we include important compiler flags, such as -fPIC (ocaml/dune#5816, fixes ocaml/dune#5809).
@emillon emillon deleted the ps/rr/fix__tweak_flags_for_3_3 branch October 20, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants