Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5950 #5952

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Fix #5950 #5952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
- Dune no longer uses shimmed `META` files for OCaml 5.x, solely using the ones
installed by the compiler. (#5916, @dra27)

- Fix handling of the `(deps)` field in `(test)` stanzas when there is an
`.expected` file. (#5952, #5951, fixes #5950, @emillon)

3.3.1 (19-06-2022)
------------------

Expand Down
2 changes: 1 addition & 1 deletion src/dune_rules/test_rules.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ let rules (t : Dune_file.Tests.t) ~sctx ~dir ~scope ~expander ~dir_contents =
| `Expect diff ->
let rule =
{ Dune_file.Rule.targets = Infer
; deps = Bindings.empty
; deps = t.deps
; action =
( loc
, Action_unexpanded.Redirect_out
Expand Down
5 changes: 0 additions & 5 deletions test/blackbox-tests/test-cases/tests-stanza-expected-deps.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,3 @@ This is visible when trying to build the `@all` alias. See #5950.
$ cp data.txt t.expected

$ dune build t.output
File "dune", line 2, characters 7-8:
2 | (name t)
^
Fatal error: exception Sys_error("data.txt: No such file or directory")
[1]