Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ${build-number} #602

Closed
wants to merge 1 commit into from
Closed

Add ${build-number} #602

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2018

Add a ${build-number} variable which expands to the number of builds started. This provides a way to run a command that is run every time a build is started (#255).

@ghost ghost mentioned this pull request Mar 10, 2018
@ghost ghost requested a review from rgrinberg March 11, 2018 00:28
@ghost ghost force-pushed the build-number branch from af2346e to ced9c7c Compare March 11, 2018 00:31
@rgrinberg
Copy link
Member

Can we have something like a @phony alias for user to depend on? I think that having to include ${build-number} in some action is a bit unintuitive. Also, I'm not sure it's such a good idea to expose this number to users either, as in your suggested workaround in #255 (comment)

@ghost
Copy link
Author

ghost commented Mar 11, 2018

Actually, maybe the best is to be explicit and allow to say that a rule has unspecified dependencies. In the end that's what it is. Then in polling mode Dune could decide to re-run it periodically for instance. We can add a field (has_unspecified_deps) to rule and alias stanzas.

@ghost ghost closed this Mar 11, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants