fix: relax sandboxing check for dir targets #6054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a rule doesn't need sandboxing, it should still be able to produce directory targets. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: ca89fead-e8c3-41f1-a861-3916267fa439
rgrinberg
requested review from
snowleopard
and removed request for
snowleopard
snowleopard
reviewed
Aug 9, 2022
| @@ -476,10 +482,12 @@ end = struct | |||
| in | |||
| let produced_targets = | |||
| match sandbox with | |||
| | None -> | |||
| | None -> ( | |||
| (* Directory targets are not allowed for non-sandboxed actions, so | |||
| the call below should not raise. *) | |||
There was a problem hiding this comment.
That's a stale comment, right? The above change allows directory targets for some non-sandboxed actions.
snowleopard
reviewed
Aug 9, 2022
| @@ -434,7 +434,13 @@ end = struct | |||
| without sandboxing. We just need to make sure we clean up all stale | |||
| directory targets before running the rule and then we can discover | |||
| all created files right in the build directory. *) | |||
| if not (Path.Build.Set.is_empty targets.dirs) then | |||
| if | |||
There was a problem hiding this comment.
As the above comment says, we might need to do some preparation before running a non-sandboxed action that produces directory targets. What if those directories already contain some files, for example?
snowleopard
reviewed
Aug 9, 2022
|
Thanks for reviewing. I've also made an alternative to this PR: #6056 It's a bit more complex, but also much more useful in general. In that PR I've allowed all non sandboxed actions to produce directory targets. |
|
@rgrinberg I think I prefer the other, more general PR. Shall we close this one then? |
|
Yeah, I prefer the other PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a rule doesn't need sandboxing, it should still be able to produce
directory targets.
Signed-off-by: Rudi Grinberg me@rgrinberg.com
ps-id: ca89fead-e8c3-41f1-a861-3916267fa439