fix: run console in separate thread #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__run_console_in_separate_thread
branch
2 times, most recently
from
24427f9 to
2a40715
Compare
rgrinberg
force-pushed
the
ps/rr/fix__run_console_in_separate_thread
branch
from
2a40715 to
627a234
Compare
We no longer block on updating the terminal Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 230cf5db-0841-4d20-af31-5f2cf27a8432
rgrinberg
force-pushed
the
ps/rr/fix__run_console_in_separate_thread
branch
from
627a234 to
055f42f
Compare
gridbugs
approved these changes
Aug 15, 2022
|
Is the reason for this change to hide the latency of updating the terminal to prevent that latency from slowing down the build? Is there a place I can look to get context for this change (issue, etc)? |
|
It's not written anywhere, just something discussed internally by the devs. The reasons are twofold:
1. Updating the terminal indeed slows down the build as you've said.
2. We'd like to improve the tui further and that will exacerbate 1.
Rudi.
…On Aug 14, 2022, 8:43 PM -0500, Stephen Sherratt ***@***.***>, wrote:
Is the reason for this change to hide the latency of updating the terminal to prevent that latency from slowing down the build? Is there a place I can look to get context for this change (issue, etc)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer block on updating the terminal
Signed-off-by: Rudi Grinberg me@rgrinberg.com
ps-id: 230cf5db-0841-4d20-af31-5f2cf27a8432