Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS codesign hook: use nix-compatible CLI flags #6260

Merged

Conversation

anmonteiro
Copy link
Collaborator

@anmonteiro anmonteiro commented Oct 18, 2022

Signed-off-by: Antonio Nuno Monteiro anmonteiro@gmail.com

Looks like Nix exposes a darwin.sigtool binary that is compatible with /usr/bin/codesign, but it doesn't support --sign. We also need to pass -f because the binary might already be signed.

This is how dune 3.5 will be able to be packaged for nix: nix-ocaml/nix-overlays@db5f507

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@rgrinberg rgrinberg requested a review from emillon October 18, 2022 22:04
@rgrinberg rgrinberg added this to the 3.5.0 milestone Oct 18, 2022
@emillon
Copy link
Collaborator

emillon commented Oct 19, 2022

Thanks. I'll merge that without the -f part that we can discuss separately for 3.6.

@emillon emillon merged commit 85f99b3 into ocaml:main Oct 19, 2022
@anmonteiro
Copy link
Collaborator Author

The error I get without -f is:

ocaml5.0.0+alpha1-conan-cli> libc++abi: terminating with uncaught exception of type std::runtime_error: file is already signed. pass -f to sign regardless.

@anmonteiro anmonteiro deleted the anmonteiro/code-substitution-nix-compatible branch October 19, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants