macOS codesign hook: use nix-compatible CLI flags #6260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Nuno Monteiro anmonteiro@gmail.com
Looks like Nix exposes a
darwin.sigtool
binary that is compatible with/usr/bin/codesign
, but it doesn't support--sign
. We also need to pass-f
because the binary might already be signed.This is how dune 3.5 will be able to be packaged for nix: nix-ocaml/nix-overlays@db5f507