Rework the sub system select #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Merged
Split the select_backends between two functions: - one for backends that support extensions - one for backends that support replacement it might be possible to support both at once, but for now this is enough and it's simpler.
ghost
requested a review
from 
rgrinberg
approved these changes
Mar 20, 2018
| @@ -95,7 +95,7 @@ module Backend = struct | |||
| ; field "flags" Ordered_set_lang.Unexpanded.sexp_of_t t.info.flags | |||
| ; field_o "generate_runner" Action.Unexpanded.sexp_of_t | |||
| t.info.generate_runner | |||
| ; field_o "extends" (list f) (Option.map t.extends ~f:Result.ok_exn) | |||
| ; field "extends" (list f) (Result.ok_exn t.extends) ~default:[] | |||
There was a problem hiding this comment.
The change to field makes sure the compatibility with old backends, right?
There was a problem hiding this comment.
Yes, it should be the same S-expression representation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the select_backends between two functions:
it might be possible to support both at once, but for now this is enough and it's simpler.