Add a blackbox test suite for configurator #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
configurator-blackbox
branch
4 times, most recently
from
9a51af0 to
e193161
Compare
|
That seems fine, but we should mark the various internal libraries as such, so that we can continue changing the APIs. |
These will all live under the jbuilder package
rgrinberg
force-pushed
the
configurator-blackbox
branch
from
e193161 to
284d4d6
Compare
|
Okay, I mentioned that stdune/caml/ocaml_config/usexp are all internal in the synopsis and in the ocamldoc. |
Add an internal description in the synopsis and also a comment in the ocamldoc
rgrinberg
force-pushed
the
configurator-blackbox
branch
from
284d4d6 to
bd52821
Compare
ghost
approved these changes
Apr 10, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now possible after the recent improvements to the black box tests.
One slightly undesirable thing is that it also forces us to declare all the sub libraries as public as well. But I think that this is basically unavoidable and will come eventually. I don't think that the other libraries should delay the release of configurator.
@dra27 is there a convenient string valued defined we can use in the tests (for completeness).