Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dune_console): print missing newline after dune exec #6821

Merged
merged 1 commit into from
Jan 4, 2023
Merged

fix(dune_console): print missing newline after dune exec #6821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Unreleased
PPX-rewriters can be taken into account by providing the
`--with-pps` flag. (#6727, fixes #6486, @esope)

- Print missing newline after `$ dune exec`. (#6821, fixes #6700, @rgrinberg,
@Alizter)

- Fix binary corruption when installing or promoting in parallel (#6669, fixes
#6668, @edwintorok)

Expand Down
4 changes: 2 additions & 2 deletions src/dune_console/dune_console.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ module Backend = struct
module Progress_no_flush : S = struct
let status_line = ref Pp.nop

let finish () = ()

let status_line_len = ref 0

let hide_status_line () =
Expand Down Expand Up @@ -93,6 +91,8 @@ module Backend = struct

let reset () = Dumb.reset ()

let finish () = set_status_line None

let reset_flush_history () = Dumb.reset_flush_history ()
end

Expand Down