Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fiber from public libraries #6925

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Jan 24, 2023

Undo a mistake from a long time ago. Instead of releasing it from inside
dune, this library will be released from a separate repository.

The library will have its own versioning, release process, and its scope will be more than just the minimum required for dune.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

@rgrinberg rgrinberg requested a review from snowleopard January 24, 2023 02:55
@rgrinberg rgrinberg added this to the 3.7.0 milestone Jan 24, 2023
Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I believe there was an alert somewhere saying the code is unstable. Shall we drop that alert too?

Undo a mistake a long time ago. Instead of releasing it from inside
dune, this library will be released from a separate repository.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 78e669f7-a25a-4a9f-9d86-dbf37c728524 -->
@rgrinberg rgrinberg force-pushed the ps/rr/remove_fiber_from_public_libraries branch from 129a43a to 1b8cdd2 Compare January 27, 2023 07:17
@rgrinberg
Copy link
Member Author

I believe there was an alert somewhere saying the code is unstable. Shall we drop that alert too?

Dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants