Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that multiple licenses are supported #7098

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

Leonidas-from-XIV
Copy link
Collaborator

The stanza is in the singular, but in fact supports more than one license. A lot of .opam.template files exist that add a license field to be able to specify multiple licenses where this is not strictly required.

The stanza is in the singular, but in fact supports more than one
license. A lot of `.opam.template` files exist that add a `license`
field to be able to specify multiple licenses where this is not strictly
required.

Signed-off-by: Marek Kubica <marek@tarides.com>
@emillon
Copy link
Collaborator

emillon commented Feb 16, 2023

I'm fine with the change, but did you see that "Multiple licenses may be specified" is explicitly stated below?
Also note that support for several licenses came only fairly recently (#6114) so these packages might have to bump the dune version to properly use this.

@Leonidas-from-XIV
Copy link
Collaborator Author

Leonidas-from-XIV commented Feb 16, 2023

Yes, I saw the comment. I was writing #7059 (comment) and as I was analyzing which OPAM fields are in .opam.template files I saw a lot of license fields from templates, so I assumed that it might've been unclear to people that multiple licenses are allowed.

Thanks for the pointer to #6114, that (and the related linked issues) puts a new perspective on it that this has only been possible since dune 3.2, which explains why a lot of these files use license in .opam.template files.

I think the change is still useful, but maybe needs also a note on being available since dune 3.2.

@emillon emillon enabled auto-merge (squash) March 8, 2023 14:46
@emillon emillon merged commit a3ff6bf into ocaml:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants