feature: add a thread pool #7201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/feature__add_a_thread_pool
branch
from
e081b59 to
d24683b
Compare
rgrinberg
force-pushed
the
ps/rr/feature__add_a_thread_pool
branch
5 times, most recently
from
cfa1339 to
288c1af
Compare
gridbugs
approved these changes
Mar 6, 2023
Alizter
reviewed
Mar 11, 2023
rgrinberg
force-pushed
the
ps/rr/feature__add_a_thread_pool
branch
from
288c1af to
b70dbba
Compare
replace the current implementation with an unbounded number of workers Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: f6f8a745-34f1-42fd-bf92-7ca2b6bde297 -->
rgrinberg
force-pushed
the
ps/rr/feature__add_a_thread_pool
branch
from
b70dbba to
56b2f5e
Compare
snowleopard
reviewed
Mar 23, 2023
snowleopard
reviewed
Mar 23, 2023
snowleopard
reviewed
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
Scheduler.Workerwith a background thread pool. The advantage of the thread pool is that we don't spawn 3 threads per RPC client and that the pool will be useful for off loading other syscalls from the main thread. The disadvantage is that we might get worse throughput if we have many RPC clients that are slow to service.