ignore relative paths in PATH #7282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading relative paths present in PATH is fragile behaviour. We explicitly filter any relative paths when reading PATH. Signed-off-by: Ali Caglayan <alizter@gmail.com> <!-- ps-id: b71f4ba5-99be-42a7-a830-784811017345 -->
nojb
reviewed
Mar 11, 2023
There was a problem hiding this comment.
This change is more general than what I had in mind (filtering out relative paths only for the file watching mechanism), but indeed changing this across the board may make sense as it would make Dune more predictable.
There is a small chance this make break some workflows (eg someone setting PATH=.:$PATH in a CRAM test), but I am overall in favour.
|
Yeah, I suppose this could be too restrictive and heavy handed. I guess we could change it so that only watch mode filters, but I don't like the difference in behaviour between the regular build. Maybe at the end of the day, the current behaviour is the most expected by a user and we should just fix watch mode's fsevents. |
|
I don't want to do this in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading relative paths present in PATH is fragile behaviour and leads to issues such as #6907. We explicitly filter any relative paths when reading PATH.
Signed-off-by: Ali Caglayan alizter@gmail.com