Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: show running dune build in subdir fails to find project root #7348

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Mar 17, 2023

Running dune build in a subdirectory fails to find the project root. This is the underlying cause of #7344.

Signed-off-by: Ali Caglayan <alizter@gmail.com>

<!-- ps-id: 26722c1d-53ae-4a6f-8649-e36c5a8f8590 -->
@rgrinberg
Copy link
Member

root finding is disabled in tests because of INSIDE_DUNE

@Alizter
Copy link
Collaborator Author

Alizter commented Mar 17, 2023

Of course it is. I keep forgetting this.

@Alizter Alizter closed this Mar 17, 2023
@Alizter Alizter deleted the ps/rr/test__show_running__dune_build__in_subdir_fails_to_find_project_root branch March 17, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants