Switch from Apache+CLA to MIT+DCO #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2018 13:57
ghost
mentioned this pull request
|
Should we have something in the README as well? |
|
I would think |
|
Is CONTRIBUTING.md treated specially by github somehow? I suppose it's enough to leave it in CONTRIBUTING.md as other projects also seem to do it this way (I've had a look at the popular purescript project) |
|
Yh, github will invite users to read it when opening a PR. BTW, this PR wasn't supposed to be merged now, we need to wait for the missing CLA... |
|
I jumped the gun out of excitement. Okay let me revert this. Btw, I'm surprised to know that we have some missing CLA's at the moment. |
Merged
|
Yh, unfortunately we are missing two CLA documents |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the license of Dune to MIT and add a CONTRIBUTING files explaining that contributors must certify that the DCO apply to their work. Previously the license was Apache and we were asking contributors to sign the Jane Street CLA.
At the moment we are just waiting for the CLA from a couple of past contributions and then we will be ready to do the switch.