Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(coq): Add documentation for composition with installed theories #7384

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Mar 22, 2023

Doc for #7047

@Alizter Alizter added docs Documentation improvements coq labels Mar 22, 2023
@Alizter Alizter added this to the 3.8.0 milestone Apr 20, 2023
@Alizter Alizter force-pushed the ps/branch/doc_coq___add_documentation_for_composition_with_installed_theories branch from 553c223 to 6c4bc69 Compare April 20, 2023 19:07
@Alizter Alizter marked this pull request as ready for review April 20, 2023 19:07
Copy link
Collaborator

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting/grammar suggestions. One typo caught.

doc/coq.rst Outdated Show resolved Hide resolved
doc/coq.rst Show resolved Hide resolved
doc/coq.rst Show resolved Hide resolved
doc/coq.rst Show resolved Hide resolved
doc/coq.rst Outdated Show resolved Hide resolved
doc/coq.rst Outdated Show resolved Hide resolved
doc/coq.rst Outdated Show resolved Hide resolved
doc/coq.rst Outdated Show resolved Hide resolved
doc/coq.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@ejgallego ejgallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo a typo it looks good to me.

I would do some further rewriting as noted in the comments but I'm happy we do that in a subsequent PR.

@ejgallego ejgallego self-assigned this Apr 25, 2023
@ejgallego ejgallego force-pushed the ps/branch/doc_coq___add_documentation_for_composition_with_installed_theories branch 2 times, most recently from 42f7ab5 to 40c0f25 Compare May 1, 2023 21:29
Co-authored-by: Emilio Jesus Gallego Arias <e+git@x80.org>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the ps/branch/doc_coq___add_documentation_for_composition_with_installed_theories branch from 40c0f25 to 8409d8a Compare May 2, 2023 10:31
@Alizter
Copy link
Collaborator Author

Alizter commented May 2, 2023

@ejgallego Thanks for the explanation of the databases. I have gone ahead and cleaned up the wording a bit and will merge later.

@Alizter Alizter merged commit 08aaf59 into ocaml:main May 2, 2023
@Alizter Alizter deleted the ps/branch/doc_coq___add_documentation_for_composition_with_installed_theories branch May 2, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coq docs Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants