feat(melange): support enabled_if in melange.emit
#7848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/melange-enabled-if
branch
from
e7e6422 to
7b933d2
Compare
jchavarri
approved these changes
Jun 1, 2023
rgrinberg
reviewed
Jun 1, 2023
|
|
||
| $ cat > dune-project <<EOF | ||
| > (lang dune 3.8) | ||
| > (using melange 0.1) |
There was a problem hiding this comment.
Is this still 0.1? If so, I don't think there's a need to version any changes.
rgrinberg
reviewed
Jun 1, 2023
| > let () = Js.log "hello" | ||
| > EOF | ||
|
|
||
| Not available until dune lang 3.9 |
There was a problem hiding this comment.
If this field needs versioning, it should be using the melange syntax rather than the dune syntax.
anmonteiro
force-pushed
the
anmonteiro/melange-enabled-if
branch
from
7b933d2 to
50129c4
Compare
|
Removed the versioning. I can add docs in a follow-up. |
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/melange-enabled-if
branch
from
50129c4 to
2ab6f05
Compare
rgrinberg
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tangentially related to #7717