Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a jbuilder transition package #796

Merged
6 commits merged into from May 28, 2018
Merged

Add a jbuilder transition package #796

6 commits merged into from May 28, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2018

This should help with #792. Now when running opam pin add jbuilder --dev, the installation fails if dune is not installed with the following message:

=-=- jbuilder.transition troubleshooting =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
=> Jbuilder has been renamed and the jbuilder package is now a transition package.
=> Use the dune package instead.
=> 
=> If you want to try the development version of Dune before the 1.0.0 is released, run the following command:
=> 
=> $ opam pin add dune https://github.com/ocaml/dune.git

@ghost ghost requested a review from rgrinberg May 23, 2018 14:18
jbuilder.opam Outdated
"Jbuilder has been renamed and the jbuilder package is now a transition package."
"Use the dune package instead."
""
"If you want to try the development version of Dune before the 1.0.0 is released, run the following command:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrap this line to 76 cols

@ghost
Copy link
Author

ghost commented May 28, 2018

make test finds a cycle between the jbuilder and dune packages. I wonder if it's not because of the README.md and other files we automatically install

@@ -0,0 +1,22 @@
opam-version: "1.2"
version: "transition"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMIIW, shouldn't this be transitions? (or the one in dune.opam should be transition.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's the one in dune.opam that's wrong. Thanks for pointing that out

jeremiedimino and others added 6 commits May 28, 2018 14:04
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
@ghost ghost merged commit 1860438 into ocaml:master May 28, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants