-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a jbuilder transition package #796
Conversation
jbuilder.opam
Outdated
"Jbuilder has been renamed and the jbuilder package is now a transition package." | ||
"Use the dune package instead." | ||
"" | ||
"If you want to try the development version of Dune before the 1.0.0 is released, run the following command:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe wrap this line to 76 cols
|
@@ -0,0 +1,22 @@ | |||
opam-version: "1.2" | |||
version: "transition" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMIIW, shouldn't this be transitions
? (or the one in dune.opam
should be transition
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it's the one in dune.opam that's wrong. Thanks for pointing that out
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
This should help with #792. Now when running
opam pin add jbuilder --dev
, the installation fails if dune is not installed with the following message: