fix: dune hang on macOS #8087
Closed
fix: dune hang on macOS #8087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/fix-8083
branch
3 times, most recently
from
4a63e9d to
daa97a3
Compare
|
This seems to fix all previously broken packages. CI run green at nix-ocaml/nix-overlays#916 |
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/fix-8083
branch
from
daa97a3 to
cb961d6
Compare
|
Once it's confirmed as the right fix I'll cut a 3.9.1 with this. |
|
Thanks for the investigation. I disabled the feature properly in #8100 until we address the races. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive attempt at fixing #8083.
Separating these calls seems to fix the problem we're seeing on macOS.
I'm not sure why this is the case, though, so consider this PR a starting point for discussion.