Upstream Jane Street changes to Dune engine

[dkalinichenko-js]

+ minor changes to Stdune and Dune rules

[Alizter]

Do we want to expose the stop_on_first_error behaviour to the user via a config option?

[Alizter]

What's the difference between this and the field above?

[dkalinichenko-js]

First one is for selecting the appropriate action runner based on the actions, second one is for notifying all action runners. Merging those is non-trivial since selection depends on some JS-specific code. We plan to refactor this but for now we're trying to minimize the diff between our version and upstream.

[Alizter]

Very well. Can you include a comment in the mli that says this will be refactored at a later date? Descriptions of the fields would also be nice but not necessary.

[rgrinberg]

As discussed offline: the test suite reveals that our cycles errors aren't marshallable. We should be able to fix that.

I've glanced over the code and there's a couple of things I've noticed that are missing:

1. Stdout/Stderr truncation introduced by Jesse
2. The recording of action duration in Action_exec

I'm not sure if that was intentional, but it's fine to introduce these changes in subsequent PR's if you prefer.

[dkalinichenko-js]

Do we want to expose the stop_on_first_error behaviour to the user via a config option?

That would be nice, we implemented that at JS but our front-end is different.

[dkalinichenko-js]

I've glanced over the code and there's a couple of things I've noticed that are missing:

1. Stdout/Stderr truncation introduced by Jesse
2. The recording of action duration in Action_exec

I'm not sure if that was intentional, but it's fine to introduce these changes in subsequent PR's if you prefer.

Yeah, both are intentional, I'll do it in later PRs.

[Alizter]

Very well. Can you include a comment in the mli that says this will be refactored at a later date? Descriptions of the fields would also be nice but not necessary.

[Alizter]

Do we want to expose the stop_on_first_error behaviour to the user via a config option?

That would be nice, we implemented that at JS but our front-end is different.

OK, once this PR is merged we should open an issue about adding this feature in. We can discuss the details in the issue.

[dkalinichenko-js]

Looks like it's not just cycle errors that can be raised in Action_exec with dynamic dependencies.

[Alizter]

Looks like coveralls is getting confused by this branch being named main and also reporting the coverage here as mains coverage. I'll let them know upstream.