Implement --build-dir and change Path.t to use symbolic paths #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change is implement the --build-dir feature. This feature lets us control the build directory which previously always defaulted to _build. To accomplish this, Path.t had to be modified to be: External of External.t | In_source_tree of Local.t | In_build_dir of Local.t To represent the 3 kinds of paths dune is dealing with. The In_build_dir constructor in particular, is relative to Path.root or some external path. A few other refactorings had to be done to support this transition: * The workspace is now "settable". This means that we no longer have to pass it explicitly when converting local to absolute paths. * Path.is_local no longer makes sense and is renamed to Path.is_managed. Roughly, is_managed identifies paths in the build and source directories. * Path.absoulte has been renamed of_filename_relative_to_initial_cwd * Path.Local.root is now "." (as opposed to "") Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
|
@diml Same PR but with CHANGES.md and a manual entry. |
ghost
approved these changes
Jun 2, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change is implement the --build-dir feature. This
feature lets us control the build directory which previously always defaulted to
_build. To accomplish this, Path.t had to be modified to be:
External of External.t | In_source_tree of Local.t | In_build_dir of Local.t
To represent the 3 kinds of paths dune is dealing with. The In_build_dir
constructor in particular, is relative to Path.root or some external path.
A few other refactorings had to be done to support this transition:
The workspace is now "settable". This means that we no longer have to pass it
explicitly when converting local to absolute paths.
Path.is_local no longer makes sense and is renamed to Path.is_managed.
Roughly, is_managed identifies paths in the build and source directories.
Path.absoulte has been renamed of_filename_relative_to_initial_cwd
Path.Local.root is now "." (as opposed to "")
Signed-off-by: Rudi Grinberg rudi.grinberg@gmail.com