Make the output of Dune deterministic in tests #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
rgrinberg
reviewed
Jun 6, 2018
| else | ||
| loop (Filename.concat acc "..") (Filename.dirname dir) | ||
| in | ||
| loop ".." (Filename.dirname s) |
There was a problem hiding this comment.
Why can't we just use Path.descendant here? I'm a bit worried that that we're hitting that annoying infinite loop case again if dir ends up being an absolute path.
There was a problem hiding this comment.
Currently Path.descendant doesn't work for absolute paths. Here the two paths come from Sys.getcwd, so I assumed they'd be normalized.
rgrinberg
approved these changes
Jun 6, 2018
When the root is not the cwd, print a relative path for the "Entering ..." line rather than an absolute one. Signed-off-by: Jeremie Dimino <jdimino@janestreet.com>
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the root is not the cwd, print a relative path for the
Entering ...line rather than an absolute one. This way we no longer need the2>&1 | grep -v Entering.