dune_console: make refresh rate configurable and default INSIDE_EMACS to 15 #8812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2023
rgrinberg
reviewed
Oct 2, 2023
Alizter
force-pushed
the
ps/branch/dune_console__make_framerate_configurable_and_default_inside_emacs_to_15
branch
2 times, most recently
from
bf1ad8c to
1a6f167
Compare
rgrinberg
reviewed
Oct 2, 2023
rgrinberg
reviewed
Oct 2, 2023
Alizter
force-pushed
the
ps/branch/dune_console__make_framerate_configurable_and_default_inside_emacs_to_15
branch
2 times, most recently
from
f7a569e to
d6f260c
Compare
rgrinberg
reviewed
Oct 2, 2023
Alizter
force-pushed
the
ps/branch/dune_console__make_framerate_configurable_and_default_inside_emacs_to_15
branch
from
d6f260c to
3913542
Compare
rgrinberg
reviewed
Oct 3, 2023
|
Can you add a CHANGES entry? |
Alizter
force-pushed
the
ps/branch/dune_console__make_framerate_configurable_and_default_inside_emacs_to_15
branch
from
828a04b to
b07e02d
Compare
|
I've added a chnagelog entry. I don't really know what to do about the "copy pasted code" as I am not sure where it should live. |
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/branch/dune_console__make_framerate_configurable_and_default_inside_emacs_to_15
branch
from
b07e02d to
2d89802
Compare
|
@rgrinberg I've moved |
Alizter
deleted the
ps/branch/dune_console__make_framerate_configurable_and_default_inside_emacs_to_15
branch
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 28, 2023
Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
Nov 28, 2023
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Nov 28, 2023
CHANGES: - Introduce `$ dune ocaml doc` to open and browse documentation. (ocaml/dune#7262, fixes ocaml/dune#6831, @EmileTrotignon) - `dune cache trim` now accepts binary byte units: `KiB`, `MiB`, etc. (ocaml/dune#8618, @Alizter) - No longer force colors for OCaml 4.03 and 4.04 (ocaml/dune#8778, @rgrinberg) - Introduce new experimental odoc rules (ocaml/dune#8803, @jonjudlam) - Introduce the `runtest_alias` field to the `cram` stanza. This allows removing default `runtest` alias from tests. (@rgrinberg, ocaml/dune#8887) - Do not ignore libraries named `bigarray` when they are defined in conjunction with OCaml 5.0 (ocaml/dune#8902, fixes ocaml/dune#8901, @rgrinberg) - Dependencies in the copying sandbox are now writeable (ocaml/dune#8920, @rgrinberg) - Absent packages shouldn't prevent all rules from being loaded (ocaml/dune#8948, fixes ocaml/dune#8630, @rgrinberg) - Correctly determine the stanza of menhir modules when `(include_subdirs qualified)` is enabled (@rgrinberg, ocaml/dune#8949, fixes ocaml/dune#7610) - Display cache location in Dune log (ocaml/dune#8974, @nojb) - Re-run actions whenever `(expand_aliases_in_sandbox)` changes (ocaml/dune#8990, @rgrinberg) - Rules that only use internal dune actions (`write-file`, `echo`, etc.) can now be sandboxed. (ocaml/dune#9041, fixes ocaml/dune#8854, @rgrinberg) - Do not re-run rules when their location changes (ocaml/dune#9052, @rgrinberg) - Correctly ignore `bigarray` on recent version of OCaml (ocaml/dune#9076, @rgrinberg) - Add `test_` prefix to default test name in `dune init project` (ocaml/dune#9257, fixes ocaml/dune#9131, @9sako6) - Add `coqdoc_flags` field to `coq` field of `env` stanza allowing the setting of workspace-wide defaults for `coqdoc_flags`. (ocaml/dune#9280, fixes ocaml/dune#9139, @Alizter) - [coq rules] Be more tolerant when coqc --print-version / --config don't work properly, and fallback to a reasonable default. This fixes problems when building Coq projects with `(stdlib no)` and likely other cases. (ocaml/dune#8966, fix ocaml/dune#8958, @Alizter, reported by Lasse Blaauwbroek) - Dune will now run at a lower framerate of 15 fps rather than 60 when `INSIDE_EMACS`. (ocaml/dune#8812, @Alizter) - dune-build-info: when `version=""` is found in a `META` file, we now return `None` as a version string (ocaml/dune#9177, @emillon) - Dune can now be built and installed on Haiku (ocaml/dune#8795, fix ocaml/dune#8551, @Alizter) - Mark installed directories in `dune-package` files. This fixes `(package)` dependencies against packages that contain such directories. (ocaml/dune#8953, fixes ocaml/dune#8915, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the refresh rate of the dune console configurable from dune_config. The default value is 60 frames per second like before but now we also default to 15 if
INSIDE_EMACSis set. I've also validated the range between0 < x <= 1000which is arbitrary but I don't see any use case for such large frame rates. This is also very useful for testing dune console.