Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(engine): allow customizing execution parameters per context #8932

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Oct 12, 2023

Contexts are a way for users to customize the rules in a workspace and build all these workspaces concurrently. This PR makes it possible to customize the execution parameters per context, giving us additional customization possibilities for free.

In addition, it's also good to make the engine as agnostic to contexts as possible. It gives the rules more flexibility and makes the engine assume less about the rules.

Here's a related ticket that describes the motivation more: #7049

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: b94e5764-cd7b-4dcb-92b1-366487c2046a -->
@rgrinberg rgrinberg requested a review from snowleopard October 12, 2023 19:42
@rgrinberg
Copy link
Member Author

@pmwhite could you review this one as well?

@pmwhite
Copy link
Collaborator

pmwhite commented Oct 20, 2023

Looks good. I don't see where the behavior changed, though. Would it be easy enough to write a test that demonstrates using different execution parameters in different contexts? Or if that's too much of a pain, maybe just elaborate in this PR a bit more. What you said seems clear enough to someone with more context, but I don't have very much - at least not about this corner of Dune's feature set.

@rgrinberg
Copy link
Member Author

rgrinberg commented Oct 20, 2023

I don't see where the behavior changed, though

There should be no change in behavior.

Would it be easy enough to write a test that demonstrates using different execution parameters in different contexts?

It should be easy, but there's no way to do this yet. We can only modify the execution context via project files and there's no way to do that yet.

I'll update the description to include more context.

@pmwhite
Copy link
Collaborator

pmwhite commented Oct 20, 2023

Ahh, I see now. We're expanding what the engine can do, but not changing behavior for existing use-cases. Makes sense! Thanks for explaining.

@rgrinberg rgrinberg merged commit afa34ed into main Oct 20, 2023
20 checks passed
@rgrinberg rgrinberg deleted the ps/rr/feature_engine___allow_customizing_execution_parameters_per_context branch October 20, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants