Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: improve dune pkg lock message #8959

Merged

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Oct 18, 2023

We use Pp.enumerate when printing packages in a lock file. Affecting the output of dune pkg lock and dune describe pkg lock. Additionally:

  • The "Contents of dune.lock" message is given the Success tag.
  • The extra space after dune pkg lock is removed.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter requested a review from rgrinberg October 18, 2023 00:41
@rgrinberg rgrinberg merged commit 07b5d04 into ocaml:main Oct 18, 2023
20 checks passed
@Alizter Alizter deleted the ps/branch/pkg__improve_dune_pkg_lock_message branch October 18, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants