Make --dev the default
#920
Conversation
ghost
requested review from
doc/usage.rst
Outdated
| @@ -364,7 +364,7 @@ write a ``(profile ...)`` stanza. For instance: | |||
|
|
|||
| .. code:: scheme | |||
|
|
|||
| (profile dev) | |||
| (profile performances) | |||
There was a problem hiding this comment.
In that case, I believe that it is an is uncountable noun, and so we should use performance. Or maybe we can use a predefined profile name, like (profile release)?
| $ dune runtest --root explicit-interfaces | ||
| Entering directory 'explicit-interfaces' | ||
| main alias runtest | ||
| hello | ||
|
|
||
| CR-someday diml: this is weird that we need to do that: |
There was a problem hiding this comment.
That seems weird, what happens if this is not added? If that's not fixable immediately, I think we should replace this CR- comment by a link to a bug report.
There was a problem hiding this comment.
It seems that the file is not copied back from the source tree on every run. I've noticed this before but haven't take the time to investigate. I'll prepare a test to expose the behavior
There was a problem hiding this comment.
For this PR I just changed the test to create the modified files in run.t
There was a problem hiding this comment.
Yes, that seems better that way indeed!
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
ghost
mentioned this pull request
Following this discussion this PR changes the default build profile to be
dev. The rationale being that most of the time we want to compile the things we work on in development mode.The
-pflags which must be used in opam file still implies--profile release.Since this is technically a breaking changes, this behavior is only enabled for the
dunebinary. To do so this PR adds a moduleWhich_programindicating which one ofduneorjbuilderthe current running program is. It uses the workaround for library variants described here./cc @yminsky and @jberdine who tested the build profile feature