chore: update vendored opam #9221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
reviewed
Nov 19, 2023
I've also modified the vendor script slightly so that we do a more efficient "git clone" by simply fetch the commit we want straight from the remote and checking it out locally. Downloading opam takes a long time, so I think this is a good idea. We can eventually consolidate a lot of the common funcitons in the vendor update scripts and do the same everywhere. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/branch/chore__update_vendored_opam
branch
from
d7ad3de to
840f13e
Compare
|
@rgrinberg I've reverted the cloning changes. I still think its a good idea, but I'll do them in another PR with some more sharing between the scripts so that we don't have so much copy-paste and they are fatser. The reason I noticed with opam is because the download is very large and I have a slow internet connection at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also modified the vendor script slightly so that we do a more efficient "git clone" by simply
fetching the commit we want straight from the remote and checking it out locally. Downloading opam takes a long time, so I think this is a good idea.We can eventually consolidate a lot of the common functions in the vendor update scripts and do the same everywhere.