test(pkg): invalid package dependency bug #9269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
reviewed
Nov 22, 2023
| > (depends foo.1.2.3)) | ||
| > EOF | ||
|
|
||
| $ dune pkg lock 2>&1 | head -n1 |
There was a problem hiding this comment.
What's the error message when we try to build the project?
If we have a good error message, it should come regardless if the user is using this feature or not.
There was a problem hiding this comment.
There is no error message, only a complaint that the package is empty. When passing (allow_empty) there is still no error.
There was a problem hiding this comment.
Okay, then please include this in a separate test outside of pkg/. I think this is where we should fix the issue first.
There was a problem hiding this comment.
OK I've done that in #9271. I'm keeping this test since it's specifically about dune pkg lock.
Alizter
deleted the
ps/branch/test_pkg___invalid_package_dependency_bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9270