Improve compatibility of Configurator.V1.write_flags #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the produced file will round-trip with both the Dune and Jbuilder lexical conventions. Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
ghost
requested a review
from 
ghost
mentioned this pull request
rgrinberg
approved these changes
Jul 8, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't checked in detail but I'm pretty sure the following is true:
sQuoted_string sin dune syntaxQuoited_string s'wheres = s'This is not true if we use
Atom (A s)instead ofQuoted_string s. With this in mind, this PR change the files produced byConfigurator.V1.write_flagsto make sure they produce only quoted strings.