Remove --skip-update and make it implied when possible
#9683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
changed the title
--skip-update--skip-update and make it implied when possible
Leonidas-from-XIV
force-pushed
the
remove-skip-update
branch
from
b2b091e to
613c93c
Compare
rgrinberg
approved these changes
Jan 10, 2024
gridbugs
approved these changes
Jan 11, 2024
The only place where offline mode would work is if the repositoy URL didn't specify any hash or specified a hash that exists in the rev store. It is easier to make the distinction on whether to update dependent on the Source than an CLI option (which if used wrong will just make dune fail). Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
After the update it might either exist or still not in which case the previous error is valid. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
remove-skip-update
branch
from
613c93c to
13d7e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place where offline mode would work is if the repositoy URL didn't specify any hash or specified a hash that exists in the rev store.
It is easier to make the distinction on whether to update dependent on the
Sourcethan an CLI option (which if used wrong will just make dune fail).I've fixed
of_opam_urlto update the repo if the revision was not found locally and is not a tag or branch, that way specifying a revision can work offline if the rev store is up to date but will transparently go online if it is out of date.Closes #9354