Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] backport #9811 #9924

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[3.13] backport #9811 #9924

merged 3 commits into from
Feb 5, 2024

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Feb 5, 2024

@emillon emillon mentioned this pull request Feb 5, 2024
Closed
15 tasks
@emillon
test: add repro for ocaml#9538 (subst on 32-bit) (ocaml#9539)
70265cb 
Signed-off-by: Etienne Millon <me@emillon.org>
@emillon
refactor: detect large files in Io functions (ocaml#9828)
2626603 
`Io.read_all` and related functions read the contents of a file in a
string, which has a size limit (`Sys.max_string_length`) and can be an
issue in 32-bit systems. This makes an explicit check and raises a
`Code_error` in these situations.

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon
fix(subst): ignore large files (ocaml#9811)
0d431df 
Fixes ocaml#9538

This logs a warning for large files (>16MB on 32-bit systems).

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon merged commit a7d49bd into ocaml:3.13 Feb 5, 2024
26 of 27 checks passed
@emillon emillon deleted the backport-9811 branch February 5, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emillon