Rename %{root} to %{workspace_root} #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
emillon
approved these changes
Jul 10, 2018
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two notions of root in dune:
dune-projectfile (or at least one<package>.opamfor compatibility with jbuilder)The latter is often equal to the former, expect when a package is vendored. Looking at the dune-universe, many projects are currently using
${ROOT}when they should really be using${SCOPE_ROOT}.${SCOPE_ROOT}was renamed%{project_root}in dune. To make things even more explicit, this PR renames%{root}to%{workspace_root}.