Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merlin reports wrong error for “shadowed” identifiers #533

Closed
smondet opened this issue May 22, 2016 · 1 comment
Closed

Merlin reports wrong error for “shadowed” identifiers #533

smondet opened this issue May 22, 2016 · 1 comment

Comments

@smondet
Copy link

smondet commented May 22, 2016

With Merlin pinned to https://github.com/the-lambda-church/merlin.git#reason-0.0

I get the same error with Reason and OCaml files (and from Atom and Neovim):

In a file:

let x = 42;
let x () => 42;

I get this error from Merlin:

Error: Values do not match:
         let x : unit => int
       is not included in
         let x : int: /Users/sebastienmondet/test2.re:1
@let-def
Copy link
Contributor

let-def commented May 22, 2016

Fixed in master. Need to find a way to sync with Reason.

@let-def let-def closed this as completed May 22, 2016
ddickstein added a commit to ddickstein/merlin that referenced this issue Jan 26, 2022
This reverts commit 7efcb22.

The problem reported in ocaml#533 is not reproducible when this commit is reverted,
so it's likely that the underlying Neovim bug that caused it has been resolved.
The fix introduces a problem where the window is scrolled (ocaml#1221), so this
commit reverts it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants