Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing tests on Windows #1298

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

emillon
Copy link
Contributor

@emillon emillon commented Apr 2, 2021

This ensures that dune runtest works on Windows: if Windows runners are added to ocaml-ci, this will not break the build, and failures can be fixed incrementally.

@emillon emillon force-pushed the windows-disable-tests branch from d1ff891 to 0083e2f Compare April 2, 2021 10:12
@emillon
Copy link
Contributor Author

emillon commented Apr 2, 2021

Remark about the PR itself: I included 3 solutions depending on how you prefer:

  1. individual (subdir) stanzas in the test dune file - this can be useful if you want to generate these
  2. nested (subdir) stanzas in the test dune file - a bit more DRY
  3. tests disabled in their own file close to the test. I think it's better since filenames are less duplicated (files can be moved more easily) but that's more files

If you prefer 1 we could extend the dune support for (applies_to) so that (cram (applies_to a/b)) is a shorthand for (subdirs a (cram (applies_to b))).

@voodoos
Copy link
Collaborator

voodoos commented Apr 2, 2021

I think I am more in favour of option 3 anyway.

@emillon emillon force-pushed the windows-disable-tests branch from 0083e2f to 8132209 Compare May 7, 2021 13:55
This ensures that `dune runtest` works on Windows: if Windows runners
are added to ocaml-ci, this will not break the build, and failures can
be fixed incrementally.
@emillon emillon force-pushed the windows-disable-tests branch from 8132209 to 8674d1d Compare May 11, 2021 13:25
@voodoos voodoos merged commit ae21420 into ocaml:master May 11, 2021
voodoos added a commit to voodoos/merlin that referenced this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants