Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs fixes: log arguments in merlin-debug-last-commands, compute line offsets correctly #981

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Emacs fixes: log arguments in merlin-debug-last-commands, compute line offsets correctly #981

merged 3 commits into from
Jun 24, 2019

Commits on Jun 24, 2019

  1. Revert "Simplify cons" 

    This reverts commit 8d55864.
The list is encoded this way to allow the 'setcdr' mutation three lines
below:
- the message with a nil field is added to the log buffer
- after getting an answer, this field is mutated to store its content

The benefit is that we still get an entry in the log buffer even if the
mode crashes before getting an answer.
This is ugly, but fit on 3 lines :O.
    Frédéric Bour committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    88158f8 View commit details
    Browse the repository at this point in the history

  2. fix #975: compute line offset as a number of characters

    Frédéric Bour committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    196db67 View commit details
    Browse the repository at this point in the history

  3. use byte positions

    Frédéric Bour committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    965efeb View commit details
    Browse the repository at this point in the history