Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytecode target does not install stublibs anymore #117

Open
olafhering opened this issue Jul 20, 2017 · 5 comments
Open

bytecode target does not install stublibs anymore #117

olafhering opened this issue Jul 20, 2017 · 5 comments

Comments

@olafhering
Copy link

Since commit 70c197c ("Make OCamlbuild plugin not assume that dynamic linking is supported.") the shared stublibs are not installed anymore. Reverting that change on top of 2e34867 fixes the issue.

@ygrek
Copy link

ygrek commented Jul 20, 2017

Debian is patching this -> ygrek/extunix#23

@gildor478
Copy link
Member

Relevant bug (initial bug report):
https://forge.ocamlcore.org/tracker/?func=detail&group_id=54&aid=1251&atid=291

P. Snively solution was to not request for building them and not install them.

If I understand the issue, we should not ask to build them but install them if present.

@glondu
Copy link

glondu commented Jul 21, 2017

No, they should always be built and installed.

@glondu
Copy link

glondu commented Jul 21, 2017

OK, I've just read the linked bug report. I wasn't considering cross-compilation.

If I understand the issue, we should not ask to build them but install them if present.

I agree with "install them if present", but I don't understand what is meant by "ask to build them".

@gildor478
Copy link
Member

@glondu you are right, this has nothing to do with "ask to build them", this is all about linking with them,

Here is what should be done:

  • install the stublibs if they are generated
  • don't LINK with them on bytecode platform

In 70c197c, this will mean that we revert the OASISLibrary part, but we keep the MyOcamlbuildBase part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants