Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to update metaModel #1058

Closed
wants to merge 0 commits into from
Closed

Attempt to update metaModel #1058

wants to merge 0 commits into from

Conversation

qua3k
Copy link

@qua3k qua3k commented Mar 30, 2023

I'm not exactly sure how to generate the types. Running dune runtest --auto-promote && dune fmt --auto-promote just deleted a bunch of code.

@qua3k
Copy link
Author

qua3k commented Mar 30, 2023

Fixes #1056

@rgrinberg
Copy link
Member

you can run dune build @cinaps --auto-promote; dune build @fmt --auto-promote to regenerate from the metamodel.

@qua3k
Copy link
Author

qua3k commented Mar 31, 2023

you can run dune build @cinaps --auto-promote; dune build @fmt --auto-promote to regenerate from the metamodel.

I did that, but there is no difference.

@qua3k
Copy link
Author

qua3k commented Mar 31, 2023

Actually, I think that the changes I made are really broken. The type alias for Uri to string was removed, so there was some trouble where it was undefined, and I tried to have it directly be defined as a string, but that broke a bunch of other code that expected a Uri.t.

@rgrinberg
Copy link
Member

How about we start with porting only the change to metamodel that's required to fix the issue with DocumentSelector? Later, we can worry about updating everything else.

@qua3k
Copy link
Author

qua3k commented Apr 1, 2023

How about we start with porting only the change to metamodel that's required to fix the issue with DocumentSelector? Later, we can worry about updating everything else.

Okay, so I reset my branch to HEAD@master but I get the same error after using the output of dune build @cinaps --auto-promote; dune build @fmt --auto-promote

How did you generate this previously?

duckie@macbook ocaml-lsp λ make all                                  
dune build @all
File "lsp/src/types.ml", line 1345, characters 42-53:
1345 |     Json.To.literal_field "kind" "delete" yojson_of_t t
                                                 ^^^^^^^^^^^
Error: Unbound value yojson_of_t
Hint: Did you mean yojson_of_int?
Hint: If this is a recursive definition,
you should add the 'rec' keyword on line 1344
make: *** [all] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants