-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for URI fragments #1387
Conversation
Do you have examples of requests to the server that require correct handling of these fragments ? Or is it that you use the |
I am using lsp in my own language server where I would like to send a URI with a fragment to the client. Specifically, I'm trying to use the |
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Thanks for the contribution. I think you forgot to promote the test. Can you review them at If those look correct to you, this PR is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good to me!
LGTM. Bear in mind that the LSP library offers no API stability. |
Pull Request Test Coverage Report for Build 4589Details
💛 - Coveralls |
This is useful because in VSCode, file system URIs can contain line numbers in the fragment:
file:///path#N
.