Cookbook Send a POST/PATCH Request w/ Authentication #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggsmith842
changed the title
christinerose
approved these changes
Jun 25, 2024
cuihtlauac
requested changes
Jun 27, 2024
data/cookbook/make-http-post-request-bearer-auth/00-cohttp_lwt.ml
Outdated
Show resolved
Hide resolved
Comment on lines
52
to
58
| let headers = | ||
| Header.init () | ||
| |> fun h -> | ||
| Header.add h "Accept" "application/vnd.github+json" | ||
| |> fun h -> | ||
| Header.add h "Authorization" "Bearer <your token goes here>" | ||
| |> fun h -> Header.add h "X-GitHub-Api-Version" "2022-11-28" |
There was a problem hiding this comment.
It would be easier to read using a local definition such as:
let header_add s1 s2 h = Header.add h s1 s2 inThere was a problem hiding this comment.
I believe I updated it to do what you are saying. I'm very new to Ocaml so please let me know if this isn't what you meant.
Comment on lines
62
to
64
| >>= fun (response, body) -> | ||
| let code = response |> Response.status |> Code.code_of_status in | ||
| body |> Cohttp_lwt.Body.to_string >|= fun body -> code, body |
There was a problem hiding this comment.
Aren't binding operators available instead of binary operators there?
There was a problem hiding this comment.
Same as above. I'm new to this but using binding operators does make it make much easier to read! Thank you.
ggsmith842
changed the title
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
christinerose
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added task to web programming section to show how to send data via a POST request. I wondered if it would be beneficial to have a section dedicated to working with REST APIs in general?
Will add cookbook examples that send data with POST and returns a response.