-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook for invert a matrix using owl library #2632
base: main
Are you sure you want to change the base?
Conversation
Hi @RCHG! Thanks for requesting my review. Forgive the delay, as I was on holiday for the past two weeks. Just mostly minor grammar/formatting things. I think I caught a missing word |
Thanks for the update. You are right: the statement should be "close to zero". In pure math they have to be zero but, I guess, in computer algorithms we can only guarantee a tiny float number. Everything seems to be fine now. |
packages: [owl] | ||
--- | ||
|
||
(* Creates an Owl `float` matrix using random numbers drawn from a uniform distribution with `Owl.Mat.uniform`. It is very likely that it will be invertible but we ensure it by checking that the determinat is not zero with `Owl.Linalg.D.dat`. The dimensions of the matrix are defined by `m`. *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(* Creates an Owl `float` matrix using random numbers drawn from a uniform distribution with `Owl.Mat.uniform`. It is very likely that it will be invertible but we ensure it by checking that the determinat is not zero with `Owl.Linalg.D.dat`. The dimensions of the matrix are defined by `m`. *) | |
(* Creates an Owl `float` matrix using random numbers drawn from a uniform distribution with `Owl.Mat.uniform`. It is very likely that it will be invertible, but we ensure it by checking that the determinat is not zero with `Owl.Linalg.D.dat`. The dimensions of the matrix are defined by `m`. *) |
Should the word be "determinant" or is "determinat" correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar correction and a possible typo
Thank you, yes it should be determinant. Also it should be |
Adding suggested changes by christinerose
This seems to be finished and ready, but their integration seems frozen since Aug. Do I need to do something more? Thanks. |
Hello. I have created a cookbook recipe for "invert a matrix" using the Owl library. My 1st cookbook, so happy to introduce changes/improvements where needed.